-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gerrit support #19
Comments
Note: tracked on @wikimedia's phabricator too: https://phabricator.wikimedia.org/T180962 |
I claimed this task on @wikimedia's phabricator and working on it now |
Hey @Phantom-42, let's have a little discussion over here about the UX design of this PR. Currently you've implemented the following:
usually, when adding a new service, what I start with are the basic operations:
then I might play with some tougher APIs:
Now given the nature of gerrit, things might happen differently with it. But the questions are:
I believe that feedback work (generally speaking, commenting/reading/acting on issues (#104) and PRs) is the next must-have feature of so as you're working on it, @Phantom-42, may I ask you for your opinion? (and @jayvdb as well, of course). |
Well, the most actively used functions (
There are not snippets/gists/etc on Gerrit, however we need to focus on developing functionality related to patchset reviewing instead. I will think more about this and will notify if I have any thoughts. |
I've had a thought about interactions. As far as I remember last time I used gerrit (that was when I contributed some patches to some obscure Qt library), the process was:
so how I'd see things, that would be: # I got a bunch of commit to submit for reviewing
git gerrit add # adds the gerrit remote to the current local repository
git gerrit request create # creates and fetches a new request as local ref
git co local/refs/of/patchset/being/reviewed
# make changes
git push -f gerrit or # I got a bunch of commit to submit for reviewing
git gerrit add # adds the gerrit remote to the current local repository
git gerrit request list # lists the requests being reviewed
git gerrit request fetch refs/of/patchset/being/reviewed # fetches a patchset to review
git co local/refs/of/patchset/being/reviewed
# make changes
git push -f gerrit also, a nice to have feature, even though it's definitely not a must have, would be the |
No description provided.
The text was updated successfully, but these errors were encountered: