Unit testing

[aronbeal]

Hi,

I'm attempting to do some unit testing using a class that utilizes the promises library. Here's the general approach (in a file MyTest.php):

use PHPUnit\Framework\TestCase;
use GuzzleHttp\Promise\FulfilledPromise;

class MyTest extends TestCase {

  /**
   * Tests unit testing with callbacks.
   */
  public function testFoo() {
    $p = new FulfilledPromise("");
    $me = $this;
    $p->then(function() use ($me) {
        $me->assertTrue(TRUE, "Foo promise returning method succeeded.");
        print (sprintf("%s::%s line %s: Success callback executed\n", get_class($this), __FUNCTION__, __LINE__));
    }, function() use ($me) {
        $me->assertTrue(FALSE, "Foo promise returning method succeeded.");
        print (sprintf("%s::%s line %s: Failure callback executed\n", get_class($this), __FUNCTION__, __LINE__));
    });
  }
}

The test completes without any assertions occurring (at least, none whose output is recognized by the testing suite). It appears the callbacks execute after the unit test completes:

PHPUnit 5.2.9 by Sebastian Bergmann and contributors.

Runtime:       PHP 5.6.18 with Xdebug 2.3.3
Configuration: [excluded]

.                                                                   1 / 1 (100%)

Time: 154 ms, Memory: 5.25Mb

OK (1 test, 0 assertions)
MyTest::{closure} line 91: Success callback executed

Do you know of a decent approach to using PHPUnit with Guzzle promises?

[mtdowling]

You need to call wait on the promise or manually tick the promise queue.

On Jul 7, 2016, at 8:06 AM, Aron Beal notifications@github.com wrote:

Hi,

I'm attempting to do some unit testing using a class that utilizes the promises library. Here's the general approach (in a file MyTest.php):

use PHPUnit\Framework\TestCase;

class MyTest extends TestCase {

/**

• Tests unit testing with callbacks.
  */
  public function testFoo() {
  $p = new FulfilledPromise("");
  $me = $this;
  $p->then(function() use ($me) {
  $me->assertTrue(TRUE, "Foo promise returning method succeeded.");
  print (sprintf("%s::%s line %s: Success callback executed\n", get_class($this), FUNCTION, LINE));
  }, function() use ($me) {
  $me->assertTrue(FALSE, "Foo promise returning method succeeded.");
  print (sprintf("%s::%s line %s: Failure callback executed\n", get_class($this), FUNCTION, LINE));
  });
  }
  }
  The test completes without any assertions occurring (at least, none whose output is recognized by the testing suite). It appears the callbacks execute after the unit test completes:

PHPUnit 5.2.9 by Sebastian Bergmann and contributors.

Runtime: PHP 5.6.18 with Xdebug 2.3.3
Configuration: [excluded]

. 1 / 1 (100%)

Time: 154 ms, Memory: 5.25Mb

OK (1 test, 0 assertions)
MyTest::{closure} line 91: Success callback executed
Do you know of a decent approach to using PHPUnit with Guzzle promises?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[aronbeal]

Can you tell me where? I tried changing the method to:

  /**
   * Tests unit testing with callbacks.
   */
  public function testFoo() {
    $p = new FulfilledPromise("");
    $me = $this;
    $p->then(function() use ($me) {
        $me->assertTrue(TRUE, "Foo promise returning method succeeded.");
        print (sprintf("%s::%s line %s: Success callback executed\n", get_class($this), __FUNCTION__, __LINE__));
    }, function() use ($me) {
        $me->assertTrue(FALSE, "Foo promise returning method succeeded.");
        print (sprintf("%s::%s line %s: Failure callback executed\n", get_class($this), __FUNCTION__, __LINE__));
    });
    $p->wait();
  }

but the problem remains. 1 test, 0 assertions

[aronbeal]

Oh wow. I'm highly overcomplicating this.

  /**
   * Tests unit testing with callbacks.
   */
  public function testFoo() {
    $p = new FulfilledPromise(TRUE);
    $result = $p->then(function() {
        return TRUE;
    }, function() {
        return FALSE;
    })->wait();
    $this->assertTrue($result, "Testing foo");
  }

Nm. :)

[aronbeal]

And thank you, by the way. Appreciate the help.