Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught Promises should throw Exception #74

Closed
davidbarratt opened this issue Jul 24, 2017 · 1 comment
Closed

Uncaught Promises should throw Exception #74

davidbarratt opened this issue Jul 24, 2017 · 1 comment

Comments

@davidbarratt
Copy link

davidbarratt commented Jul 24, 2017

I've noticed (#73) that uncaught errors do not throw exceptions, this can make debugging really difficult because there isn't an obvious reason of why a promise chain is breaking.

I believe in JavaScript, an uncaught promise error throws a fatal error, so I think throwing an exception (outside of the promise chain) for uncaught promises would be a good idea here.

@davidbarratt
Copy link
Author

oh... well, all() does this but settle() does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant