Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

withParentHeader should not be visible? #15

Closed
sagikazarmark opened this issue May 29, 2015 · 1 comment
Closed

withParentHeader should not be visible? #15

sagikazarmark opened this issue May 29, 2015 · 1 comment

Comments

@sagikazarmark
Copy link
Member

Request overrides the withHeader method declared in MessageTrait, so the original one is aliased to withParentHeader.

Shouldn't it be protected or private?
@mtdowling
Copy link
Member

Ah yes, that would be ideal.

@sagikazarmark sagikazarmark mentioned this issue May 29, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtdowling @sagikazarmark