Function GuzzleHttp\Psr7\parse_request($message) doesn't support absolute URI's.

[poison]

I was wondering why parse_request doesn't support absolute URI's. Request like this fail:

GET https://www.google.com HTTP/1.1

The regex explicity requires a starting slash after the keyword:

if (!preg_match('/^[a-zA-Z]+\s+\/.*/', $data['start-line'])) {
    throw new \InvalidArgumentException('Invalid request string');
}

Are there any objections to support absolute URI's as well? I'm trying to build a php proxy server using reactphp/http (which uses guzzle/psr7) and it doesn't work because of this. If no objections I can create a PR.

Best,
Nicolas

[mtdowling]

Sounds fine to me.

On Jul 7, 2015, at 3:24 PM, Nicolas notifications@github.com wrote:

I was wondering why parse_request doesn't support absolute URI's. Request like this fail:

GET https://www.google.com HTTP/1.1
The regex explicity requires a starting slash after the keyword:

if (!preg_match('/^[a-zA-Z]+\s+/.*/', $data['start-line'])) {
throw new \InvalidArgumentException('Invalid request string');
}
Are there any objections to support absolute URI's as well? I'm trying to build a php proxy server using reactphp/http (which uses guzzle/psr7) and it doesn't work because of this. If no objections I can create a PR.

Best,
Nicolas

—
Reply to this email directly or view it on GitHub.

[poison]

Were you able to check my PR #25 ? Any comments on it ?

Best,
Nicolas

[mtdowling]

PR #25 looks good, but I added a question to it: #25 (comment)