Question

[harikt]

Hi,

I was going through the guzzle code, have a doubt regarding the implementation

psr7/src/MessageTrait.php

Line 99 in 0c79977

$new->headers[strtolower($header)][] = $value;

Doesn't it need to preserve the case sensitivity? See

https://github.com/php-fig/http-message/blob/f3218d1cdf479cd9a65d568f605edbc17c6df82a/src/MessageInterface.php#L118

While header names are case-insensitive, the casing of the header will be preserved by this function, and returned from getHeaders()

and I am seeing

psr7/src/MessageTrait.php

Line 42 in 0c79977

return $this->headerLines;

public function getHeaders()
{
    return $this->headerLines;
}

I understand it finally is returning the preserved value. But does headerLines in headers is a bit confusing? I wished the variable name is like

public function getHeaders()
{
    return $this->headers;
}

public function getHeaderLines()
{
    return $this->headerLines;
}

Thank you

[mtdowling]

This repo hasn't been updated to reflect recent changes to psr-7. We hope to get to it soon though.

On Apr 16, 2015, at 8:37 AM, Hari K T notifications@github.com wrote:

Hi,

I was going through the guzzle code, have a doubt regarding the implementation

psr7/src/MessageTrait.php

Line 99 in 0c79977

$new->headers[strtolower($header)][] = $value;

Doesn't it need to preserve the case sensitivity? See

https://github.com/php-fig/http-message/blob/f3218d1cdf479cd9a65d568f605edbc17c6df82a/src/MessageInterface.php#L118

While header names are case-insensitive, the casing of the header will be preserved by this function, and returned from getHeaders()
and I am seeing

psr7/src/MessageTrait.php

Line 42 in 0c79977

return $this->headerLines;

public function getHeaders()
{
return $this->headerLines;
}
I understand it finally is returning the preserved value. But does headerLines in headers is a bit confusing? I wished the variable name is like

public function getHeaders()
{
return $this->headers;
}

public function getHeaderLines()
{
return $this->headerLines;
}
Thank you

—
Reply to this email directly or view it on GitHub.

[harikt]

Thank you @mtdowling for the fast reply.

[mtdowling]

Everything should now be up to date