Unable to read response's body contents

[SilverFire]

Commit 45054d9#diff-f89246dce7e387482b2c6c584a5e7e9dR97 have introduced a bug by comparing $body with empty string.

I did not dug too deeply to find out the real reason of wrong behavior, but I guess it is caused by implicit calling of GuzzleHttp\Psr7\Stream::__toString() in order to cast object to string to make a comparison.

How to reproduce

        $client = new \GuzzleHttp\Client(['base_uri' => 'https://google.com.ua/']);
        $response = $client->request('GET');
        $html = $response->getBody()->getContents();

What is expected

$html contains a response HTML

What do we have instead

$html is an empty string

Patch?

Rolling back that line to if ($body !== null) fixes the problem. Not sure whether it is a proper fix.

Environment

PHP 5.6.20
Ubuntu 16.04
guzzle/psr7@dev-master

[SilverFire]

Merging commit: 28d8dbf

[mtdowling]

Yes, this appears to be a regression that will need to be reverted.

[Tobion]

I'm fixing this.

[GrahamCampbell]

👍

[Tobion]

See #96

[BenBezac]

Was looking for a solution all the day and found this issue ;x

I rolled back to 1.3. and now i wait for the update ;)

[Tobion]

I'm kinda surprised that so many developers seem to be relying on an unreleased, unstable version (dev-master). And for this library it doesn't even seem necessary as it is getting regular tags (unlike some other libraries where you might be forced to dev versions).