Refactor rules for class_def and arguments #135
Conversation
lysnikolaou
changed the title
lysnikolaou
force-pushed
the
class-def-args
branch
from
99ea20a
to
8c45477
Compare
| ''' | ||
| class C(A, x=2, *[B, C], y=3): | ||
| pass | ||
| '''), |
There was a problem hiding this comment.
I think we are missing a case with *args and **kwargs at the same time, which is valid in current Python:
>>> class A(x,y,*something,**more_something): pass
There was a problem hiding this comment.
Oh yes, thats right! Another problem is that this currently allows generator expressions in the arguments, which is not valid Python, if I'm not mistaken.
Edit: Never mind my comment about genexprs, I had already fixed that, but forgot about it. Also, I added one more test case.
lysnikolaou
changed the title
|
@pablogsal @gvanrossum Is it okay if I push a PR that builds up on this for issues #126 and #136? |
|
Yeah, as long as you’re not afraid of some merge conflicts.
--
--Guido (mobile)
|
data/simpy.gram
Outdated
| seq_extract_starred_exprs(p, a), | ||
| seq_delete_starred_exprs(p, a), | ||
| EXTRA) } | ||
| | a=posarg b=[',' c=args { c }] { |
There was a problem hiding this comment.
Looks like we can get rid of posarg and instead write a=named_expression here -- the case where posarg matches starred_expression is already handled by the first alternative.
(Things are still weird -- one confusing thing is that starred_expression must start with *, while named_expression may or may not contain a := operator. But I don't think we can simplify further, since the resolution of "ambiguities" is quite subtle for this rule.)
Closes #122.