Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the Clear Completed Tasks feature #3

Merged
merged 2 commits into from Jun 4, 2022

Conversation

gvgesanto2
Copy link
Owner

Description

Task: https://github.com/microverseinc/curriculum-javascript/blob/main/todo-list/m2_interactive_list.md

This PR makes the following changes:

  • Adds the clear all completed tasks feature

Plus, it adopts the following methodologies and conventions:

  • For the CSS/Sass:
    • BEM methodology for naming the CSS classes
    • A modified version of the Scalable and Modular Architecture for CSS (SMACSS) methodology for organizing the CSS code into categorized folders/files (base, components, layout, and utilities)
    • Atomic Design methodology for breaking down the CSS components into atoms, molecules, and organisms
  • For the JavaScript:
    • MVC architecture to separate the application business logic from the presentation logic (DOM manipulation tasks)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (no linters errors)
  • I have checked my code and corrected any misspellings
  • I have commented my code
  • I have deleted any unused code as comments in my codebase

Screenshots

todo-add-remove

Copy link

@OmarRamoun OmarRamoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Project Approved! 🏆

Hi @gvgesanto2 👋

Your project is complete! ✔️ 🏁

Finally, you did it! 🎉 👏. Your code was very professional 💯 and I can see you have a great chance to be a Great Software Engineer ⛑️.

There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉. And Welcome to Microverse 👋.

Note: You can now take a break even if short before you move on to the next project. Happy 😄 Coding 🖥️! and Have a nice day 🌞.

Highlights 🌟

  • ✔️ Descriptive commmit messsages
  • ✔️ Descriptive PR description
  • ✔️ No linter Errors
  • The code is top-notch! 💯 and have a huge potential.

Cheers and Happy coding!👏👏👏

Important Notes 📝

  • Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
  • Please, remember to tag me in your question so I can receive the notification.

Thank you for your time 🙏 and call me if you need help or clarification ☎️

  • This is My GitHub: @omarramoun
  • This is My Twitter: @omarramoun
  • This is My Slack: Ramoun

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@gvgesanto2 gvgesanto2 merged commit e1a00ae into main Jun 4, 2022
@gvgesanto2 gvgesanto2 deleted the clear-completed-feature branch June 4, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants