Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add tests for all the TasksList methods and features #8

Merged
merged 1 commit into from Jun 10, 2022

Conversation

gvgesanto2
Copy link
Owner

Description

Task: https://github.com/microverseinc/curriculum-javascript/blob/main/todo-list/tests_2.md

This PR makes the following changes:

  • Adds tests for the TasksList.setTaskDescription() method (responsible for editing the task description)
  • Adds tests for the TasksList.removeCompletedTasks() method (responsible for removing all completed tasks)
  • Adds tests for the TasksList.toggleTaskIsCompleted() method (responsible for updating a task isCompleted status)
  • Adds tests for the TasksList.updateTasksIndexes() method (responsible for updating the tasks indexes)
  • Removes unused functions (from the id.utils.js file) and methods (from the Task.js file)

Plus, it adopts the following methodologies and conventions:

  • For the CSS/Sass:
    • BEM methodology for naming the CSS classes
    • A modified version of the Scalable and Modular Architecture for CSS (SMACSS) methodology for organizing the CSS code into categorized folders/files (base, components, layout, and utilities)
    • Atomic Design methodology for breaking down the CSS components into atoms, molecules, and organisms
  • For the JavaScript:
    • MVP architecture (a variation of the MVC pattern) to separate the application business logic from the presentation logic (DOM manipulation tasks)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Tests (changes related to testing)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (no linters errors)
  • I have checked my code and corrected any misspellings
  • I have commented my code
  • I have deleted any unused code as comments in my codebase

Screenshots

all-tests-tasks-list

@ShoiraTa
Copy link

STATUS: APPROVED ✔️


Hi @gvgesanto2 ,

Your project is complete! Great job for nailing it right on the first attempt 🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 :shipit: . Congratulations! 🎉💯🌟

giphy

Cheers and Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread by mentioning my Github username if something is not 100% clear.


As described in the Code reviews limits policy you have limited number of reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.

@gvgesanto2 gvgesanto2 merged commit 8903f6f into main Jun 10, 2022
@gvgesanto2 gvgesanto2 deleted the add-tests branch June 10, 2022 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants