Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lookahead version selection strategy #10

Open
gvlasov opened this issue Jul 22, 2015 · 0 comments
Open

Implement lookahead version selection strategy #10

gvlasov opened this issue Jul 22, 2015 · 0 comments
Assignees
Milestone

Comments

@gvlasov
Copy link
Owner

gvlasov commented Jul 22, 2015

Version 0.1 was developed with an incorrect assumption that to get the version of the file, we should track its parent commits until we find a tag. However, a tagged commit has to be created after all the changes going into that release. Therefore, by default the plugin should trace children instead of parents in the search for the closest tag. The old strategy can probably still be useful sometimes, so classes implementing it should not be removed just yet.

@gvlasov gvlasov self-assigned this Jul 22, 2015
@gvlasov gvlasov added this to the 0.2.0 milestone Jul 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant