Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes from Kent #1

Open
jkanner opened this issue Mar 25, 2020 · 0 comments
Open

Notes from Kent #1

jkanner opened this issue Mar 25, 2020 · 0 comments

Comments

@jkanner
Copy link
Contributor

jkanner commented Mar 25, 2020

---- First Tutorial (1.1) ----

When loading up the tutorial I get:

Unrecognized runtime "igwn-py37"; defaulting to "python3" Notebook settings

... but it seems to work just fine anyway

even though the instructions explicitly call out uncommenting the #!pip line, I find myself forgetting this when repeating the tutorials and am sure it will trip up a few people.

When running the tutorial, I get a popup window about the notebook not being authored by Google. You need to select "RUN ANYWAY" in the popup, which might be good to document under "Option1: Google co-labs" here:

https://github.com/gw-odw/odw-2020/blob/master/setup.md

I was able to fake it when going through the Exercises at the bottom of the first tutorial and get the answers. They of course require adding code and it took me a while to figure out a way to add code and not generate an error. Maybe some suggestion for best way to "perform" the process of adding and running code for these exercises would be helpful.

A few times when doing some action (maybe reloading pages) under the colab.research.google.com website, I was directed to a login window for github. I'm not sure what that was for, unless maybe I was invoking an auto-save feature. It might be good to have something about making a github account and what it will be needed for, in case this happens to attendees.

I thought it would be useful to dig a bit deeper into the "gwosc" package since it appears prominently in the first tutorial. A google search came up with

https://gwosc.readthedocs.io/en/latest/index.html

but I don't know if that is the official documentation for this package. Adding links for it (or the truly official) documentation for the package might be helpful to participants.

---- Second Tutorial (1.2) ----

Under Finding open data, it suggests that you will be using L1, but further suggests that you could have just as easily use G1, H1, V1. This is true for many events, but not all. Also, even though the comment specifies L1, the code is using H1. (This is just below line [18] comments)

This tutorial rapidly brings in matplotlib features, would a link to "more info" be useful?

---- Third Tutorial (index.ipynb) ----

Starting with line [4], there is a switch from using gwosc package to using gwpy package functions. Might be nice to call this out to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant