Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4 Delete video card #5

Closed
6 of 7 tasks
Gw3i opened this issue Aug 15, 2022 · 2 comments
Closed
6 of 7 tasks

#4 Delete video card #5

Gw3i opened this issue Aug 15, 2022 · 2 comments

Comments

@Gw3i
Copy link
Owner

Gw3i commented Aug 15, 2022

Value Proposition

As a user
I want to delete videos in my feed
So that I won't see them in my feed anymore

Description

Delete button

Delete pop-up message

Acceptance Criteria

  • On click on the delete button, a popup is displayed to confirm the delete
  • The data for the video card will be deleted as well

Tasks

  • Add a delete icon at top-right of every video card
  • Add onClick function to delete the video card
  • Add popup with question text, cancel button and delete button
  • Write test to check if the video card is deleted after clicking on delete button
  • Write test to check if the popup is showing after clicking on delete button

Complexity

L

@RobertBReich
Copy link

Hy Vlady,
clean and simple. 😃

cheers
R.

@ahohnsen
Copy link

Hey Vlady,

Well done! Just one comment: I still do not know what the little box at the bottom of the video card is supposed to be 🤔 maybe you can make that more clear in your scribble.

In your acceptance criteria you do not need to write what is already visible in the scribble (e.g. An delete button is on every video card at the top-right corner). Maybe it would be also nice if the video is not deleted instantly. When the user clicks on the delete button, a modal could open where the user needs to confirm deleting the video or he/she can abort the process. 🙂

@Gw3i Gw3i closed this as completed Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants