postgres driver query bug ?

[remoe]

I have troubles with postgres driver from osgEarth

Part of my log:

PG: PostgreSQL version string : 'PostgreSQL 9.1.2 on x86_64-unknown-linux-gnu, compiled by gcc (GCC) 4.4.5 20110214 (Red Hat 4.4.5-6), 64-bit'

PG: PQexec(DECLARE executeSQLCursor CURSOR for SELECT * FROM 'b_table_test_text_1') = PGRES_FATAL_ERROR
PG: PQexec(FETCH 0 in executeSQLCursor) = PGRES_FATAL_ERROR

It has to do with the following

FeatureCursorOGR::FeatureCursorOGR(OGRDataSourceH dsHandle,
                                   OGRLayerH layerHandle,
                                   const FeatureProfile* profile,
                                   const Symbology::Query& query,
                                   const FeatureFilterList& filters )
...
        from = std::string("'") + from + std::string("'"); // this is not needed

...

This quoting is not needed. When i remove this it works. But i using PG 9.1.

i use the following parameters for configure the driver:

feature_opt.connection() = "PG:dbname='map' host=host.com port=5432 user='postgres' tables=b_table_test_text_1";
style_selector.query()->expression() = "display_level = 1";

Thanks
Remo

[remoe]

Hi

When you look at the documentation of PostGres then table names are identifiers also in older versions:

http://www.postgresql.org/docs/8.2/static/sql-syntax-lexical.html
http://www.postgresql.org/docs/9.1/static/sql-syntax-lexical.html

This can be quoted with double-quotes but NOT with single quotes.

Can someone please confirm this ? Thanks.

[gwaldron]

Remo,

I guess the issue is that different back ends have different syntax. So somehow we need to account for that. Any suggestions?

[remoe]

Glenn, but please look at the lexical - docs. It says that single quotes are not correct.

[gwaldron]

Not correct for Postgres. But they are correct for OGR SQL, and possibly other OGR drivers. When the back-end driver supports SQL, OGR passes the SQL string along to the driver. But different drivers supports different flavors of SQL. I'm saying we need a way to account for that.

[remoe]

Ok, thanks. I need to read some docs and code ;)

[jasonbeverage]

Remo, try doing a pull and see if it works for you now. I made a change to only quote the table name if contains spaces and I'm also checking to see if the driver is PostgreSQL, and if it is using double quotes instead of single quotes as the delimiter.

[remoe]

@jasonbeverage , thanks, it works now.