Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't build with new hint #14

Closed
abbradar opened this issue Mar 28, 2016 · 8 comments
Closed

Doesn't build with new hint #14

abbradar opened this issue Mar 28, 2016 · 8 comments

Comments

@abbradar
Copy link

A simple solution might be to place an upper bound hint < 0.5.0.

@jwaldmann
Copy link
Contributor

for documentation purposes, the error message during the build is:

[4 of 5] Compiling Mueval.Interpreter ( Mueval/Interpreter.hs, dist/build/Mueval/Interpreter.o )

Mueval/Interpreter.hs:22:82:
    Module
    ‘Language.Haskell.Interpreter’
    does not export
    ‘glasgowExtensions’

@int-e
Copy link

int-e commented May 23, 2016

FWIW, a kind Hackage trustee (bergmark) has added an upper bound on hint to the hackage version of mueval.

@nomeata
Copy link

nomeata commented Jun 1, 2016

This affects the Debian package of mueval; as we try to track LTS releases, we would need a version of mueval compatible with hint 0.5.

gwern, have you considered joining stackage?

@int-e
Copy link

int-e commented Jun 5, 2016

see also lambdabot/lambdabot#145

@jonschoning
Copy link

The following patch appears to work at first glance

 Mueval/Interpreter.hs | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Mueval/Interpreter.hs b/Mueval/Interpreter.hs
index 2522fd7..2850f4c 100644
--- a/Mueval/Interpreter.hs
+++ b/Mueval/Interpreter.hs
@@ -18,8 +18,8 @@ import           System.IO (openTempFile)
 import           Data.List

 import           Language.Haskell.Interpreter (eval, set, reset, setImportsQ, loadModules, liftIO,
-                                     installedModulesInScope, languageExtensions,
-                                     typeOf, setTopLevelModules, runInterpreter, glasgowExtensions,
+                                     installedModulesInScope, languageExtensions, availableExtensions, 
+                                     typeOf, setTopLevelModules, runInterpreter,
                                      OptionVal(..), Interpreter,
                                      InterpreterError(..),GhcError(..),
                                      Extension(UnknownExtension))
@@ -47,7 +47,7 @@ interpreter Options { extensions = exts, namedExtensions = nexts,
                       packageTrust = trust,
                       trustedPackages = trustPkgs,
                       modules = m } = do
-                                  let lexts = (guard exts >> glasgowExtensions) ++ map readExt nexts
+                                  let lexts = (guard exts >> availableExtensions) ++ map readExt nexts
                                   -- Explicitly adding ImplicitPrelude because of
                                   -- http://darcsden.com/jcpetruzza/hint/issue/1
                                   unless (null lexts) $ set [languageExtensions := (UnknownExtension "ImplicitPrelude" : lexts)]
-- 
2.7.4

@niteria
Copy link
Contributor

niteria commented Jul 12, 2016

This is blocking adding lambdabot to stackage. Is @jonschoning's patch satisfactory? I can send a pull request with his patch if it helps.

@niteria
Copy link
Contributor

niteria commented Aug 11, 2016

@chrisdone: Can you also make a new release on hackage?

@chrisdone
Copy link
Collaborator

Bumped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants