Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when sequences are smaller than max_seq #15

Closed
ccolas opened this issue Dec 13, 2021 · 4 comments
Closed

Bug when sequences are smaller than max_seq #15

ccolas opened this issue Dec 13, 2021 · 4 comments

Comments

@ccolas
Copy link

ccolas commented Dec 13, 2021

Hi!
Small bug to correct, line 92 of the e_piano.py file:

tgt[raw_len] = TOKEN_END throws an error because raw_len is out of bounds. This should be raw_len-1. This is not a problem with the maestro dataset, which probably contains more than max_seq=2048 events for all performances, but this can show up in custom datasets.

@gwinndr
Copy link
Owner

gwinndr commented Dec 15, 2021

Thanks for letting me know! I'll take a look.

@CNelias
Copy link
Contributor

CNelias commented May 24, 2022

I ran into the same issue (and fixed it exactly like ccolas).

@gwinndr
Copy link
Owner

gwinndr commented May 25, 2022

Ack! I fixed this, but forgot to commit and push! Will fix

@gwinndr
Copy link
Owner

gwinndr commented May 26, 2022

Fixed, my apologies

@gwinndr gwinndr closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants