Fixed non-ANSI code #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @juanjosegarciaripoll , your patch was applied in master in 4077fad by David Cooper in 2018. Unfortunately it wasn't attributed to you, and the master branch has since moved on so I would prefer not to edit history anymore, I hope that's ok. I'm closing this PR as it has been completed now. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LOOP statements, a WHILE cannot appear before a FOR statement. This is not valid ANSI code, as per the specification http://www.lispworks.com/documentation/HyperSpec/Body/m_loop.htm Indeed, ECL does not support this.