Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check dataset comparison for cache #252

Closed
OnnoEbbens opened this issue Aug 25, 2023 · 1 comment
Closed

Check dataset comparison for cache #252

OnnoEbbens opened this issue Aug 25, 2023 · 1 comment
Assignees
@OnnoEbbens
Labels
caching All caching related issues enhancement New feature or request

Comments

@OnnoEbbens
Copy link
Collaborator

Now that we removed the _FillValue from the DataArrays in PR #238 I think we can use xr.testing.assert_identical again instead of xr.testing.assert_equal
@OnnoEbbens OnnoEbbens self-assigned this Aug 25, 2023
@OnnoEbbens OnnoEbbens changed the title Check dataset comparison Check dataset comparison for cache Aug 25, 2023
@dbrakenhoff dbrakenhoff added the enhancement New feature or request label Nov 2, 2023
@OnnoEbbens OnnoEbbens added the caching All caching related issues label Feb 22, 2024
@OnnoEbbens
Copy link
Collaborator Author

fixed by comparing the hashes of two datasets (update from @bdestombe).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OnnoEbbens OnnoEbbens

Labels
caching All caching related issues enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbrakenhoff @OnnoEbbens