Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerate variables needed by the HTCondor workflow #376

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

duncanmmacleod
Copy link
Member

This PR closes #375 by replacing the use of getenv=true with a hardcoded set of environment variables to pass through from the submit environment.

instead enumerate the variables we want to propagate from the submit environment
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (958795b) 50.27% compared to head (bf72398) 49.65%.
Report is 18 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #376      +/-   ##
==========================================
- Coverage   50.27%   49.65%   -0.62%     
==========================================
  Files          60       60              
  Lines        8677     8824     +147     
==========================================
+ Hits         4362     4381      +19     
- Misses       4315     4443     +128     
Flag Coverage Δ
Linux 49.65% <100.00%> (-0.62%) ⬇️
python3.10 49.65% <100.00%> (-0.62%) ⬇️
python3.11 49.65% <100.00%> (?)
python3.7 ?
python3.8 ?
python3.9 49.65% <100.00%> (-0.62%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eagoetz
Copy link
Collaborator

eagoetz commented Aug 29, 2023

@duncanmmacleod Thanks, do we also need CONDA_EXE?

@eagoetz eagoetz added this to the 2.2.0 milestone Sep 12, 2023
@duncanmmacleod
Copy link
Member Author

@duncanmmacleod Thanks, do we also need CONDA_EXE?

I don't see any references to CONDA_EXE in this project.

@eagoetz eagoetz modified the milestones: 2.2.0, 2.2.1 Sep 19, 2023
@eagoetz eagoetz modified the milestones: 2.2.0, 2.2.1 Nov 1, 2023
@eagoetz eagoetz modified the milestones: 2.2.1, 2.2.2 Feb 5, 2024
@eagoetz
Copy link
Collaborator

eagoetz commented Feb 8, 2024

@duncanmmacleod Thanks, do we also need CONDA_EXE?

I don't see any references to CONDA_EXE in this project.

@duncanmmacleod the reason I ask is because the code wants to get the conda environment used at the time pages are generated. Like here: https://github.com/gwdetchar/gwdetchar/blob/f79547a178c16b9a6b9626d23d656fb025c10338/gwdetchar/io/html.py#L51. Wouldn't this mean we need CONDA_EXE or maybe you are saying we do not because gwsumm runs from within a conda environment. Can you confirm? Thanks

@eagoetz eagoetz modified the milestones: 2.2.2, 2.2.3 Feb 14, 2024
so that it is available in conda to generate the package list
@duncanmmacleod
Copy link
Member Author

Wouldn't this mean we need CONDA_EXE or maybe you are saying we do not because gwsumm runs from within a conda environment. Can you confirm? Thanks

I have added CONDA_EXE.

@eagoetz eagoetz modified the milestones: 2.2.3, 2.3.0 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove getenv=true as a (default) condor_submit command
2 participants