You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
Wanting to use DateTimeImmutable for DateRange, but the typehint is current DateTime.
Moving to DateTimeInterface would be ideal, but this is PHP5.5+ only.
Polyfilling of the DateTimeInterface and DateTimeImmutable is all possible, but the issue is that you cannot add the DateTimeInterface to DateTime so you would lose compatibility at some stage.
Maybe a branch for PHP5.5+ that uses DateTimeInterface typehint, rather than DateTime would be nice.
The text was updated successfully, but these errors were encountered:
I'm OK cutting a new release which just uses DateTimeInterface and drops support for anything less than PHP 5.5. PHP 5.4 is EOLed and people can continue to use older releases of this project if they cannot upgrade.
I'd also rather use DateTimeImmutable internally which would make all of the defensive cloning unnecessary.
Hi.
Wanting to use
DateTimeImmutable
forDateRange
, but the typehint is currentDateTime
.Moving to
DateTimeInterface
would be ideal, but this is PHP5.5+ only.Polyfilling of the
DateTimeInterface
andDateTimeImmutable
is all possible, but the issue is that you cannot add theDateTimeInterface
toDateTime
so you would lose compatibility at some stage.Maybe a branch for PHP5.5+ that uses
DateTimeInterface
typehint, rather thanDateTime
would be nice.The text was updated successfully, but these errors were encountered: