Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing def in screen.c #395

Closed
Soulhealer95 opened this issue Jun 29, 2023 · 2 comments
Closed

Missing def in screen.c #395

Soulhealer95 opened this issue Jun 29, 2023 · 2 comments

Comments

@Soulhealer95
Copy link

less/screen.c

Line 334 in 60050bd

#if ECHONL

unlike all other lines in this block, this line seems to have missed def in the #ifdef conditional and might cause some failures on some pre-processors like:

In file included from test.c:1:
test.c:20:5: error: missing binary operator before token "0x00000040"
   20 | #if ECHONL
      |     ^~~~~~
   ((tcflag_t)0x00000020)

Is there a reason why this is not an ifdef?

@Soulhealer95
Copy link
Author

Soulhealer95 commented Jun 29, 2023

Per GNU, this is intended to be unsigned integer type https://www.gnu.org/software/libc/manual/html_node/Local-Modes.html
but any header that defines this with a cast will fail this evaluation as pre-processors don't understand C casting

@gwsw
Copy link
Owner

gwsw commented Jun 29, 2023

Thanks, fixed in 3311221.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants