Clean jsinterop tests.

Change-Id: I3c6fb99c1fecc29c2a33b92bc2ce47323d553e72
Review-Link: https://gwt-review.googlesource.com/#/c/18740/

user/test-super/com/google/gwt/dev/jjs/super/com/google/gwt/dev/jjs/test/Java8Test.java

@@ -1604,19 +1604,35 @@ public boolean f() {
   }
 
   @JsFunction
-  interface JsFunctionInterface {
+  interface MyJsFunctionInterface {
+    int foo(int a);
+  }
+
+  public void testJsFunction_lambda() {
+    MyJsFunctionInterface jsFunctionInterface = a -> a + 2;
+    assertEquals(12, callAsFunction(jsFunctionInterface, 10));
+    assertEquals(12, jsFunctionInterface.foo(10));
+  }
+
+  private static native int callAsFunction(Object fn, int arg) /*-{
+    return fn(arg);
+  }-*/;
+
+  @JsFunction
+  interface MyJsFunctionInterfaceWithOverlay {
     Double m();
     @JsOverlay
     default Double callM() {
       return this.m();
     }
   }
 
-  private static native JsFunctionInterface createNative() /*-{
+  private static native MyJsFunctionInterfaceWithOverlay createNative() /*-{
     return function () { return 5; };
   }-*/;
+
   public void testJsFunction_withOverlay() {
-    JsFunctionInterface f = new JsFunctionInterface() {
+    MyJsFunctionInterfaceWithOverlay f = new MyJsFunctionInterfaceWithOverlay() {
       @Override
       public Double m() {
         return new Double(2.0);

user/test/com/google/gwt/core/CoreJsInteropSuite.java

@@ -23,7 +23,6 @@
 import com.google.gwt.core.interop.JsTypeArrayTest;
 import com.google.gwt.core.interop.JsTypeBridgeTest;
 import com.google.gwt.core.interop.JsTypeObjectMethodsTest;
-import com.google.gwt.core.interop.JsTypeSpecialTypesTest;
 import com.google.gwt.core.interop.JsTypeTest;
 import com.google.gwt.core.interop.JsTypeVarargsTest;
 import com.google.gwt.core.interop.NativeJsTypeTest;
@@ -42,7 +41,6 @@ public static Test suite() {
     suite.addTestSuite(JsExportOptimizationTest.class);
     suite.addTestSuite(JsTypeTest.class);
     suite.addTestSuite(JsTypeBridgeTest.class);
-    suite.addTestSuite(JsTypeSpecialTypesTest.class);
     suite.addTestSuite(JsTypeObjectMethodsTest.class);
     suite.addTestSuite(JsPropertyTest.class);
     suite.addTestSuite(JsMethodTest.class);

user/test/com/google/gwt/core/interop/JsFunctionTest.java

@@ -24,6 +24,7 @@
 
 /**
  * Tests JsFunction functionality.
+ * Note that JsOverlay and lambda's are tested in Java8Test.
  */
 @SuppressWarnings("cast")
 public class JsFunctionTest extends GWTTestCase {
@@ -249,7 +250,6 @@ class JsFuncionProperty {
   }
 
   public void testGetClass() {
-
     MyJsFunctionInterface jsfunctionImplementation =
         new MyJsFunctionInterface() {
           @Override
@@ -264,7 +264,6 @@ public int foo(int a) {
   }
 
   public void testInstanceField() {
-
     MyJsFunctionInterface jsfunctionImplementation =
         new MyJsFunctionInterface() {
           String hello = new Object().getClass().getName();
@@ -276,26 +275,6 @@ public int foo(int a) {
     assertEquals(Object.class.getName().length() + 4, jsfunctionImplementation.foo(4));
   }
 
-  // uncomment when Java8 is supported.
-//  public void testJsFunctionLambda_JS() {
-//    MyJsFunctionInterface jsFunctionInterface = a -> { return a + 2; };
-//    assertEquals(12, callAsFunction(jsFunctionInterface, 10));
-//    assertEquals(12, callAsCallBackFunction(jsFunctionInterface, 10));
-//  }
-//
-//  public void testJsFunctionLambda_Java() {
-//    MyJsFunctionInterface jsFunctionInterface = a -> { return a + 2; };
-//    assertEquals(12, jsFunctionInterface.foo(10));
-//  }
-//
-//  public void testJsFunctionDefaultMethod() {
-//    MyJsFunctionSubInterfaceWithDefaultMethod impl =
-//        new MyJsFunctionSubInterfaceWithDefaultMethod() {
-//        };
-//    assertEquals(10, impl.foo(10));
-//    assertEquals(10, callAsFunction(impl, 10));
-//  }
-
   private static native Object callAsFunction(Object fn) /*-{
     return fn();
   }-*/;

user/test/com/google/gwt/core/interop/JsTypeArrayTest.java

@@ -97,7 +97,6 @@ static class SimpleJsTypeAsAFieldHolder {
     public SimpleJsTypeAsAField[] arrayField;
   }
 
-  // TODO(rluble): Needs fixes in ImlementCastsAndTypeChecks, ArrayNormalizer and maybe type oracle.
   public void testJsTypeArray_asAField() {
     SimpleJsTypeAsAFieldHolder holder = new SimpleJsTypeAsAFieldHolder();
     fillArrayField(holder);
@@ -202,6 +201,17 @@ public void testJsTypeArray_instanceOf() {
     assertTrue(array instanceof SimpleJsTypeReturnForMultiDimArray[][][]);
   }
 
+  @JsType(isNative = true)
+  private static class UnreferencedNativeType { }
+
+  private static native Object createArray() /*-{
+    return [];
+  }-*/;
+
+  public void testJsTypeArray_unreferencedNativeArrayInstanceOf() {
+    assertTrue(createArray() instanceof UnreferencedNativeType[]);
+  }
+
   @JsFunction
   interface SomeFunction {
     int m(int i);

user/test/com/google/gwt/core/interop/JsTypeTest.java

@@ -515,6 +515,32 @@ public void testJsMethodWithDifferentVisiblities() {
     assertEquals("bar", callFunction(instance, "bar", null));
   }
 
+  @JsType(isNative = true, namespace = JsPackage.GLOBAL, name = "*")
+  interface Star {
+  }
+
+  public void testStar() {
+    Object object = new Object();
+
+    assertNotNull((Star) object);
+
+    object = Double.valueOf(3.0);
+    assertNotNull((Star) object);
+  }
+
+  @JsType(isNative = true, namespace = JsPackage.GLOBAL, name = "?")
+  interface Wildcard {
+  }
+
+  public void testWildcard() {
+    Object object = new Object();
+
+    assertNotNull((Wildcard) object);
+
+    object = Double.valueOf(3.0);
+    assertNotNull((Wildcard) object);
+  }
+
   static class ClassWithJsMethod {
     @JsMethod(name = "name")
     public String className() {