Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tapestry version #9816

Open
happyhua opened this issue Apr 3, 2023 · 1 comment
Open

Update tapestry version #9816

happyhua opened this issue Apr 3, 2023 · 1 comment

Comments

@happyhua
Copy link

happyhua commented Apr 3, 2023

There is a dependency in gwt on tapestry:tapestry:4.0.2, while this version is outdated and has vulnerability: https://devhub.checkmarx.com/cve-details/CVE-2020-17531/

Probably better to update it to tapestry version 5.

As Colin already mentioned in gitter, tapestry is only used for client compile time codegen, so it shouldn't affect any server code, and attacking it should be hard.

@tbroyer
Copy link
Member

tbroyer commented Apr 3, 2023

Fwiw, GWT only uses org.apache.tapestry.util.text.LocalizedProperties/LocalizedPropertiesLoader (and the other classes they themselves use), but tapestry on Central is not modular so GWT as deployed on Central gets the full tapestry, while it's built with a JAR that only contains the few classes it needs.
It might be better to either copy the code into GWT (repackage the trimmed JAR and include the classes in the gwt-user.jar –I have no idea why it's declared as a dependency of gwt-dev, it's only used in gwt-user) or rewrite/replace it. It looks like those classes were only there to be able to load properties files as UTF-8 rather than ISO-8859-1, but this is now possible using java.util.Properties directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants