Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical orientation? #12

Closed
asongtoruin opened this issue Sep 17, 2019 · 1 comment
Closed

Vertical orientation? #12

asongtoruin opened this issue Sep 17, 2019 · 1 comment

Comments

@asongtoruin
Copy link
Contributor

It would be interesting to be able to generate plots that were vertically orientated - i.e. rather than drawing the blocks column by column, they could be drawn row by row. I've got a basic working attempt at asongtoruin/pywaffle@e4d73b7 which adds the extra boolean kwarg vertical to do this, but I wasn't sure if this was functionality you think would be useful for the module.

For example, if we take the basic example from the examples folder:
fig = plt.figure(FigureClass=Waffle, rows=5, columns=10, values=[48, 46, 3])
this produces the following horizontal plot:
basic_horiz

If we change this to
fig = plt.figure(FigureClass=Waffle, rows=10, columns=5, values=[48, 46, 3], vertical=True)
we instead get a vertically oriented plot:

basic

Thoughts?

@gyli
Copy link
Owner

gyli commented Sep 18, 2019

Nice work. This is definitely something useful. Please feel free to submit a PR and we can test whether it works well with other parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants