Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.3 can't open certain file on Intel Mac Pro #534

Closed
2 tasks done
AfflatusX opened this issue Dec 18, 2022 · 18 comments
Closed
2 tasks done

v1.3 can't open certain file on Intel Mac Pro #534

AfflatusX opened this issue Dec 18, 2022 · 18 comments
Labels
bug Something isn't working
Milestone

Comments

@AfflatusX
Copy link

AfflatusX commented Dec 18, 2022

Is there an existing issue for this?

  • I have searched the existing issues

Have you tried the latest build?

  • I have tried the latest build

Gyroflow version

v1.3 (dev and prod)

What operating system are you using?

macOS Monterey

What GPU are you using?

AMD Radeon Pro 580X

What happened?

When trying to load video files with YUV422 10bit HEVC format, Gyroflow just shows the spinner forever without loading the video.

I noticed this is only happening on Intel Mac Pro (Xeon W + 580X Pro), but not happening on my M2 Macbook Air. Unfortunately Air's GPU doesn't seem to support the export encoding.

Is it an known issue that this format is not supported?

Relevant log output

No response

Sample video

https://www.dropbox.com/s/ni1v9bn9j2v6can/C0223.MP4?dl=0

@AfflatusX AfflatusX added the bug Something isn't working label Dec 18, 2022
@AfflatusX
Copy link
Author

Btw I think it might have something todo with gamma / color profile, the footage was shot using Sony a7s iii, Gamma S-Log3, Color Mode: S-Gamut3.Cine.

I tried to use a different file without the color profile and it seems to work on both intel and M1 mac.

@AfflatusX AfflatusX reopened this Dec 18, 2022
@AfflatusX
Copy link
Author

You can use the sample video I uploaded to Dropbox in the issue description to test it out.

@AdrianEddy
Copy link
Collaborator

I can't reproduce it on Windows or on M2 Air, and I don't have Intel Mac to test.
On your Intel mac, after the video fails to load, close gyroflow, go to "Show package contents -> Contents -> MacOS" and upload gyroflow.log file from there.

Also, what exactly do you mean by Unfortunately Air's GPU doesn't seem to support the export encoding.?
M2 has a dedicated hardware media engine and supports way more accelerated exporting formats than Intel+AMD.

@AfflatusX
Copy link
Author

AfflatusX commented Dec 18, 2022

@AdrianEddy appreciate the quick reply! Indeed windows and M2 Air works fine on my end as well.

gyroflow.log

log attached.

So the footage was shot with S-log3 - in order to preserve the light/color information, I either do a color grading before export, stablize it, then export to other format (that's what I do with Sony Catalyst Browse), or, run gyroflow and export in the same format so that I can post process it in Premiere.

With Gyroflow v1.3, when I click export, it tells me exporting as original format isn't supported (see screenshot below). I tried the other format it suggested but they mostly lose all the pixel information (because S-LOG3 is over exposed without LUT applied).

That's the reason I need to use the mac pro to do the export - since it has 32 cores on CPU.

Screen Shot 2022-12-18 at 11 20 33 AM

@AdrianEddy
Copy link
Collaborator

@wang-bin looks like the pixel format is not supported, can it be added or can we do a fallback in this case?

@AdrianEddy AdrianEddy added this to the 1.4.1 milestone Dec 19, 2022
@wang-bin
Copy link

@wang-bin looks like the pixel format is not supported, can it be added or can we do a fallback in this case?

yes. the format is almost the same as m1/2, except color range is different. i will fix it today.

@wang-bin
Copy link

@AdrianEddy try the last build

@AdrianEddy
Copy link
Collaborator

@AfflatusX please try latest dev build https://gyroflow.xyz/devbuild/?autodownload and post gyroflow.log if it's still not working

@AfflatusX
Copy link
Author

yup can confirm it's working now! Thanks for the fix!

@AfflatusX
Copy link
Author

actually before I close - @AdrianEddy / @wang-bin seems like neither 580X, Apple M2, or 3080Ti supports YUV422P10LE format for encoding.

I'm wondering is that a HW issue or a SW issue?

@AfflatusX AfflatusX reopened this Dec 22, 2022
@AdrianEddy
Copy link
Collaborator

YUV formats are not really supported by apple, they are coming from software decoders. Make sure to check Use GPU decoding under Advanced (or uncheck and re-check it), then it should use P210LE, which is equivalent to YUV422P10LE
P010LE is equivalent to YUV420P10LE

@AfflatusX
Copy link
Author

Cool thanks for the answer!

@AfflatusX
Copy link
Author

AfflatusX commented Dec 22, 2022

@AdrianEddy Tried to re-toggle the option, but It doesn't look like P210LE was given as an alternative px format - see log:
gyroflow.log

I noticed these two lines:

01:19:06 [DEBUG] (1) gyroflow::rendering: Possible encoders with Amd: [("hevc_videotoolbox", true), ("libx265", false)]

and

01:19:06 [DEBUG] (2) gyroflow::rendering::ffmpeg_processor: Codec formats: [VIDEOTOOLBOX, NV12, YUV420P, BGRA, P010LE]

@AdrianEddy
Copy link
Collaborator

Did you try on M2? Intel devices had much more limited media processing engine in the hardware

@AfflatusX
Copy link
Author

AfflatusX commented Dec 22, 2022

Yeah same results on M2. However, when choosing ProRes HQ the option showed up. I guess HEVC + P210LE isn't a valid combo for either libx265 or videotoolbox?

@wang-bin
Copy link

My m1 air supports main42210, maybe p210 is a supported format

fcc: 'hvc1' -  Apple HEVC (HW)  hw=1 {
    CodecName = HEVC;
    CodecType = 1752589105;
    DisplayName = "Apple HEVC (HW)";
    EncoderID = "com.apple.videotoolbox.videoencoder.ave.hevc";
    EncoderName = "Apple HEVC (HW)";
    IsHardwareAccelerated = 1;
    PerformanceRating = 400;
    QualityRating = 90;
    SupportedSelectionProperties =     {
        ProfileLevel =         (
            "HEVC_Main_AutoLevel",
            "HEVC_Main10_AutoLevel",
            "HEVC_Main42210_AutoLevel"
        );
    };
}

@AdrianEddy
Copy link
Collaborator

@wang-bin
Copy link

ffmpeg needs a patch to support p210. I've confirmed on my m1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants