Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: toggling stabilization also changes orientation #60

Closed
sweebee opened this issue Feb 4, 2022 · 9 comments
Closed

[Bug]: toggling stabilization also changes orientation #60

sweebee opened this issue Feb 4, 2022 · 9 comments
Labels
bug Something isn't working
Milestone

Comments

@sweebee
Copy link

sweebee commented Feb 4, 2022

Gyroflow version

v1.0.0-rc1

What operating system are you using?

MacOS 12.1

What GPU are you using?

AMD Radeon Pro 5300M

What happened?

When toggling stabilization on/off the orientation also changes, seems like a bug to me. might be related to #59

Schermafbeelding 2022-02-04 om 18 04 41

Relevant log output

No response

@sweebee sweebee added the bug Something isn't working label Feb 4, 2022
@sweebee sweebee changed the title [Bug]: toggling stabilisation also changes orientation [Bug]: toggling stabilization also changes orientation Feb 4, 2022
@alexagv
Copy link
Contributor

alexagv commented Feb 4, 2022

@sweebee thanks for the report, could you by any chance share a short Go2 clip so we can reproduce the issue?
Send it via WeTransfer etc?

And how was the camera mounted in this clip? Was it sideways or upside down by any chance?

@sweebee
Copy link
Author

sweebee commented Feb 4, 2022

the file: https://we.tl/t-XFx9w7l9W5

It was shot handheld with the lens on top (vertical) like this:

Insta360Go2-size-1024x1024

@alexagv
Copy link
Contributor

alexagv commented Feb 4, 2022

@sweebee can you send me a screenshot of the entire application so I can see all settings, lens profile etc?
Can't reproduce it here (also on Mac)

@alexagv
Copy link
Contributor

alexagv commented Feb 4, 2022

@sweebee aah, now I see. Managed to reproduce it.
Seems like the Rotation element only affects the "stabilized" preview and not the original preview 👍🏻

@sweebee
Copy link
Author

sweebee commented Feb 4, 2022

great. still made a video: https://www.youtube.com/watch?v=QcMTATE5AO0

@AdrianEddy AdrianEddy added this to the 1.1.0 milestone Jun 2, 2022
@mycosd
Copy link
Collaborator

mycosd commented Jun 3, 2022

I don't see this as a bug, it's just the label of the button is misleading. It should be called something like "toggle processing". As it just toggles between the original video and the processed video (not just stabilization).

@AdrianEddy
Copy link
Collaborator

but the main point of that button is to compare original with stabilized footage and if it rotates after toggling you lose that ability to compare. Fixing this is simple, we can just rotate QML element using rotation property when the stab toggle is off

@mycosd
Copy link
Collaborator

mycosd commented Jun 7, 2022

If you only want to compare the stabilization, you would have to apply the lens correction too.

@AdrianEddy
Copy link
Collaborator

Possibly, but just having the rotation preserved would help, and it's a quick fix.
Done in c076468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants