Borders are printed as garbage

[krytarowski]

Bug report.

Problem description

https://github.com/gyscos/cursive/blob/main/doc/tutorial_2.md

use cursive::Cursive;
use cursive::views::Dialog;

fn main() {
    let mut siv = cursive::default();

    siv.add_layer(Dialog::text("This is a survey!\nPress <Next> when you're ready.")
        .title("Important survey")
        .button("Next", show_next));

    siv.run();
}

fn show_next(s: &mut Cursive) {
    s.pop_layer();
    s.add_layer(Dialog::text("Did you do the thing?")
        .title("Question 1")
        .button("Yes!", |s| show_answer(s, "I knew it! Well done!"))
        .button("No!", |s| show_answer(s, "I knew you couldn't be trusted!"))
        .button("Uh?", |s| s.add_layer(Dialog::info("Try again!"))));
}

fn show_answer(s: &mut Cursive, msg: &str) {
    s.pop_layer();
    s.add_layer(Dialog::text(msg)
        .title("Results")
        .button("Finish", |s| s.quit()));
}

Environment

• Operating system: NetBSD chieftec 9.99.70 NetBSD 9.99.70 (GENERIC) #0: Tue Aug 11 17:40:05 CEST 2020 root@chieftec:/public/netbsd-root/sys/arch/amd64/compile/GENERIC amd64
• Backend used: ncurses
  • If using ncurses on linux, ncurses version? 6.2
• Current locale (run locale in a terminal).

LANG=""
LC_CTYPE="pl_PL.UTF-8"
LC_COLLATE="C"
LC_TIME="pl_PL.UTF-8"
LC_NUMERIC="pl_PL.UTF-8"
LC_MONETARY="pl_PL.UTF-8"
LC_MESSAGES="pl_PL.UTF-8"
LC_ALL="pl_PL.UTF-8"

• Cursive version (from crates.io, from git, ...) libcursive-04d5190404da43a1, cursive-04d5190404da43a1

[krytarowski]

Analysis of the bug in cursive: https://www.unitedbsd.com/d/233-spotify/49

[hrkfdn]

This appears to be a problem in the pancurses backend. The ncurses backend fixes it like this: https://github.com/gyscos/cursive/blob/main/cursive/src/backends/curses/n.rs#L90

I'd assume something similar needs to be done in the pancurses backend.

EDIT: It also seems to be set in the pancurses library itself: ihalila/pancurses@16139e4 -- not sure why it doesn't work on NetBSD.

[gyscos]

I updated the ncurses backend to use libc::setlocale instead of the ncurses one. Pancurses will need its own fix to do the same.
Does this help?

[krytarowski]

That's progress. Now waiting for ncurses-rs and pancurses fix.

[hrkfdn]

@krytarowski Can you confirm that this fixes the ncurses-backend on NetBSD?

[gyscos]

Pancurses may take longer to update, as the main author has been away from github for the last year or so. :S
We can always add a libc::setlocale in the backend code here, it's probably fine to run it multiple times.

[gyscos]

Well, until pancurses merges ihalila/pancurses#78, I updated the backend here to call setlocale. Does it fix your issue?

[krytarowski]

Fixed with:

[dependencies]
cursive = { git = "https://github.com/gyscos/cursive", rev = "eec4dd8e68dccddd61b2c1cc70b3aafa11a5302" }