Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Panic when opening empty menubar subtree #776

Open
DvvCz opened this issue Mar 27, 2024 · 1 comment
Open

[BUG] Panic when opening empty menubar subtree #776

DvvCz opened this issue Mar 27, 2024 · 1 comment
Labels

Comments

@DvvCz
Copy link

DvvCz commented Mar 27, 2024

Describe the bug
When creating a menubar with an empty subtree, panics when you select it in the menu.
Dealing with this as I want to create a dynamic menubar to select a file, although maybe this isn't the best approach.

To Reproduce

let mut siv = cursive::default();
siv.menubar().add_subtree("foo", Tree::new());
siv.add_global_callback(Key::Esc, |s| s.select_menubar());
siv.run();
// Then press escape, go to foo and press enter.

Expected behavior
Expected to not panic

Environment

  • OS: Linux (Nobara 39)
  • Backend used: ncurses
  • Current locale: en_US
  • Cursive version: 0.20.0
  • Nightly rust in debug build

Additional context
Assuming index OOB error "len is 0 but index is 0":

let item = &s.menu.children[i];

As panic points to around there (line 335 specifically).

@DvvCz DvvCz added the bug label Mar 27, 2024
@gyscos
Copy link
Owner

gyscos commented Mar 27, 2024

Thanks for the report!

Indeed, not panicking sounds like a better behavior :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants