Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve condition for api ping #1

Closed
pixtron opened this issue Jul 21, 2017 · 3 comments
Closed

Improve condition for api ping #1

pixtron opened this issue Jul 21, 2017 · 3 comments
Labels
change hasfix
Milestone
1.0.x

Comments

@pixtron
Copy link
Member

pixtron commented Jul 21, 2017

Improve the server fingerprinting when checking if the api is reachable

Currently the condition checks only that the server returns statusCode 401. Additionaly we could check that the server returns the www-authenticate header and that it is set to Basic realm="balloon"

https://github.com/gyselroth/balloon-client-desktop/blob/master/app/ui/startup/browser.js#L103
@raffis
Copy link
Contributor

raffis commented Jul 21, 2017

Probably balloon v2 will provide an endpoint for unauthenticated requests were you can check if it is a valid balloon server.

@raffis raffis mentioned this issue Jul 26, 2017
Closed
@raffis raffis mentioned this issue Oct 3, 2017
Closed
@raffis raffis added the change label Oct 25, 2017
@raffis raffis added this to the 1.0.x milestone Dec 4, 2017
@pixtron
Copy link
Member Author

pixtron commented Nov 19, 2018

Change in balloon server for api/v1 will be released with balloon@v2.2.0-beta1

@raffis
Copy link
Contributor

raffis commented Dec 12, 2018

Change in balloon server for api/v1 will be released with balloon@v2.2.0-beta1

Using /api/v2 for the ping.

@raffis raffis added the hasfix label Dec 12, 2018
@raffis raffis closed this as completed in 513f3da Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
change hasfix
Projects
None yet
Milestone
1.0.x
Development

No branches or pull requests
2 participants
@pixtron @raffis