Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oidc signin: TypeError: Cannot read property 'statusCode' of undefined #137

Closed
pixtron opened this issue Nov 1, 2018 · 1 comment
Closed

Comments

@pixtron
Copy link
Member

pixtron commented Nov 1, 2018

Description

Is:
If client has network access to server but for some reason not to oidc.providerUrl, oidc.signin throws an uncaught TypeError:

INFO <main> [startup]: requested oidc signin ({"idp":{"provider":"tam","clientId":"xxx","clientSecret":"xxx","providerUrl":"xxx","redirectUri":"http://127.0.0.1:13006","scope":"openid profile offline_access","imgBase64":"xxx"}})
ERROR <main> [main]: uncaught exception ({
  "error": {
    "stack":"TypeError: Cannot read property 'statusCode' of undefined
      at Request._callback (balloon-client-desktop/node_modules/@openid/appauth/src/node_support/node_requestor.ts:35:26)
      at self.callback (balloon-client-desktop/node_modules/request/request.js:186:22)
      at emitOne (events.js:116:13)
      at Request.emit (events.js:211:7)
      at Request.onRequestError (balloon-client-desktop/node_modules/request/request.js:878:8)
      at emitOne (events.js:116:13)
      at ClientRequest.emit (events.js:211:7)
      at TLSSocket.socketErrorListener (_http_client.js:387:9)
      at emitOne (events.js:116:13)
      at TLSSocket.emit (events.js:211:7)","message":"Cannot read property 'statusCode' of undefined"
  }
})

Should:
Error should be caught, and user informed, that login was not success full.

balloon desktop version

0.2.3

Your client operating system

N/A

Filesystem (If known)

N/A

balloon server version (If known)

N/A

@pixtron
Copy link
Member Author

pixtron commented Nov 8, 2018

With appauth@1.1.1 this now leads to:

AppAuthError {
  message:
   'Error: connect EHOSTDOWN x.x.x.x:443 - Local (0.0.0.0:0)',
  extras: undefined }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants