Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Becomes out of sync/unreactive when Thunderbird was opened by notification #571

Open
haarp opened this issue Sep 24, 2023 · 6 comments · May be fixed by #591
Open

Becomes out of sync/unreactive when Thunderbird was opened by notification #571

haarp opened this issue Sep 24, 2023 · 6 comments · May be fixed by #591
Labels
bug Something isn't working

Comments

@haarp
Copy link

haarp commented Sep 24, 2023

OS: Gentoo Linux
Linux Desktop Manager: Xfce (xfce4-notifyd-0.9.1, xfwm4-4.18.0)
Birdtray version: 1.11.4
Thunderbird version: 102.15.1
Birdtray origin: Ebuild
Qt version: NA

Description
When Thunderbird generates a new mail notifcation, it includes an "Activate" button. If the button is pressed, the Thunderbird is raised. In this state, Birdtray does not hide Thunderbird again when clicking on the tray icon. TB needs to be minimized manually first.

Expected behavior
Birdtray should always be able to control the TB window

To Reproduce

  1. Enable new mail notifications
  2. Press "Activate" in notification once new mail arrives
  3. Try to hide TB again by clicking on the tray icon

Thanks a lot!

@haarp haarp added the bug Something isn't working label Sep 24, 2023
@BeatLink
Copy link

Has there been any updates on this?

@gyunaev
Copy link
Owner

gyunaev commented Nov 21, 2023

No update since I don't use XFCE. Anyone else using it is invited to troubleshoot what happens in WindowTools_X11::hide() and why it doesn't hide again.

@adatum
Copy link

adatum commented Jan 17, 2024

Same issue and workaround with Birdtray 1.11.4 on Fedora 39 and MATE 1.26.2.

@jboillot
Copy link

jboillot commented Jan 26, 2024

Hello, I had the same issue with Birdtray 1.11.4 on Ubuntu 22.04 and GNOME 42.9.

After some testing, it appears that opening thunderbird via a new message notification does not trigger WindowTools_X11::show, so mHiddenStateCounter is not reset to 0.
It implies that the condition of this if statement is false

if ( checkWindowState( QX11Info::display(), mWinId, "_NET_WM_STATE_HIDDEN" ) && mHiddenStateCounter == 0 )

According to the few tests I did on my machine, the first term of the disjunction is sufficient and removing the mHiddenStateCounter == 0 test corrects the issue because, once in the tray, the first term becomes false.

However, I don't know if in the general case the second term can be ignored.

@haarp
Copy link
Author

haarp commented Jan 30, 2024

@jboillot: Unfortunately can't confirm. I compiled Birdtray without the mHiddenStateCounter check and still couldn't get it to minimize to tray after activating via notification.

@tehw0lf
Copy link

tehw0lf commented Mar 25, 2024

@jboillot can confirm, this solves the issue for me (Arch,Xfce 4.18.0,xfce4-notifyd-0.9.4, Birdtray 1.11.4 (self-compiled), TB 115.9.0)

I've opened a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants