Fix flexsearch arrow key navigation error #509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-enk
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Reproduced + verified (https://deploy-preview-509--doks.netlify.app/). Super thanks!
adhadse
pushed a commit
to adhadse/doks
that referenced
this pull request
Sep 17, 2022
Fix flexsearch arrow key navigation error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is an error due to an edge case when navigating through flexsearch results with the keyboard arrow keys.
You can reproduce the issue by entering something in the search input that produces 0 results. If you press an arrow key after, an error is thrown.
I also added
flatMapto simplify search result flattening. It's supported by most browsers: https://caniuse.com/array-flatIf you miss any browser you'd like to support because of that, I'll revert the
flatMapchange.