feat: edit link docs repo subpath #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made this PR mainly because I implemented it locally and felt it may be a good addition. No harm if you don't like the idea, or if you'd like me to change it let me know. Edit: FP because the gpg key used was incorrect, somehow my git config got messed up. |
james-d-elliott
force-pushed
the
feat-docs-repo-subpath
branch
from
c074946
to
333f6d3
Compare
Can be used if the folder with your content is in a subfolder so if your project wishes to contain code and docs in the same repo it's convenient to do so. Additionally includes some refactoring in the edit-page.html logic to make it easier to manage.
james-d-elliott
force-pushed
the
feat-docs-repo-subpath
branch
from
333f6d3
to
1b6a1ca
Compare
Bitbucket (bitbucket.org) is different to BitbucketServer, so made sure to add the distinction. Also moved a declaration closer to where it's used.
|
Nice! Surely an improvement that would fit Doks. Looks good, but I'd like to have a closer look. |
h-enk
previously requested changes
Jan 31, 2022
There was a problem hiding this comment.
One minor thing.
The default content directory always includes en. So, https://github.com/h-enk/doks/blob/b063faaf376ab9a47315177d4a11e2f63f7d4899/layouts/partials/main/edit-page.html#L23-L27 should be just:
{ $parts = $parts | append "content" .Lang $filePath }}
h-enk
dismissed
their stale review
I'll make the changes, so you don't have to
adhadse
pushed a commit
to adhadse/doks
that referenced
this pull request
Sep 17, 2022
…bpath feat: edit link docs repo subpath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be used if the folder with your content is in a subfolder so if your project wishes to contain code and docs in the same repo it's convenient to do so. Additionally includes some refactoring in the edit-page.html logic to make it easier to manage. Also added Bitbucket and BitbucketServer repo types.