fix(layouts): use the permalink instead of url #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was a bit too quick. Tested now. Your changes in this file (using
The changes in these ones (using
Note that, only Fixed: 7e39fb6 |
|
I must have missed that! Thanks for pointing it out. It was just a bad assumption based on it generating the errors in auto-default-menu. |
adhadse
pushed a commit
to adhadse/doks
that referenced
this pull request
Sep 17, 2022
fix(layouts): use the permalink instead of url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes usage of deprecated .URL parameter, and brings the menus usage of .Permakink for href's to be consistent.
Basic example
I don't think a screenshot is relevant. But I modeled these changes after the usage of .Permalink here: https://github.com/h-enk/doks/blob/master/layouts/partials/sidebar/auto-collapsible-menu.html#L41
Motivation
Removes a deprecated usage of a parameter, suppresses an error, and makes the menu's slightly more consistent.
Checks
npm run test