Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layouts): use comma for more than 2 contributors #714

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

james-d-elliott
Copy link
Contributor

@james-d-elliott james-d-elliott commented Mar 23, 2022

This makes the byline show commas on all but the last author of a blog post.

Summary

This adjusts the byline in blog posts to show and only for the last author when there are a series of authors. If you decide to go another route to fix this no hard feelings if you discard this PR. I'm not amazing at go templates/hugo, just learning as I use this theme to refactor one of the codebases I help maintain with this theme.

Basic example

firefox_TYSRPaGQI6

image

Motivation

Fixes #678

Checks

  • Read Create a Pull Request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test

This makes the byline show commas on all but the last author of a blog post.
Copy link
Member

@h-enk h-enk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

James, thanks for your effort — your solution is totally fine with me!

Inspected + tested

@h-enk h-enk merged commit b51feac into gethyas:master Mar 25, 2022
@james-d-elliott james-d-elliott deleted the fix-blog-byline branch March 30, 2022 09:53
adhadse pushed a commit to adhadse/doks that referenced this pull request Sep 17, 2022
fix(layouts): use comma for more than 2 contributors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributor names in Blog keeps getting added with "and"
2 participants