Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single navbar #782

Merged
merged 5 commits into from
Jun 21, 2022
Merged

Single navbar #782

merged 5 commits into from
Jun 21, 2022

Conversation

h-enk
Copy link
Member

@h-enk h-enk commented Jun 10, 2022

Summary

  • Drop section specific navigation bar — freeing up vertical space
  • Show (if options are set) search bar, language switch dropdown, and version switch dropdown on ALL pages — making navigation more direct
  • Make navigation bar sticky (if option is set, default true) on large + mobile screens — making navigation more direct (no need to scroll to top)
  • Make "On this page" section collapse on smaller screens — freeing up vertical space
  • Support section navigation for sections defined in ./config/_default/params.toml:
    [sections]
      sectionNav = ["docs", "guides"]

Basic example

https://deploy-preview-782--doks.netlify.app/

Snag_1ebaf75

Snag_f2df701

Motivation

  • Making navigation easier /more direct
  • Back to original design idea
  • Preparing for global search
  • Preparing for scroll to top button (option)

Checks

  • Read Create a Pull Request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test

@h-enk h-enk self-assigned this Jun 10, 2022
@h-enk h-enk added the enhancement New feature or request label Jun 10, 2022
@h-enk h-enk linked an issue Jun 10, 2022 that may be closed by this pull request
@james-d-elliott
Copy link
Contributor

Looking good!

@h-enk h-enk added this to the v0.5.0 milestone Jun 21, 2022
@h-enk h-enk merged commit 8634857 into master Jun 21, 2022
@h-enk h-enk deleted the single-navbar branch June 21, 2022 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

need sticky nav
2 participants