Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: csp invalid for global alert dismissal #788

Merged
merged 1 commit into from
Jun 21, 2022
Merged

fix: csp invalid for global alert dismissal #788

merged 1 commit into from
Jun 21, 2022

Conversation

james-d-elliott
Copy link
Contributor

@james-d-elliott james-d-elliott commented Jun 14, 2022 •
edited
Loading

Summary

The global alert dismissal is not permanent on Netlify due to the CSP not including this inline script in the policy.

sha256 alternative is sha256-Sz0IuK/4LfFJVp69F4UHK80xoxDZLOBPMJhPi0XZl3A= if preferred.

Basic example

TBA

Motivation

TBA

Checks

  • Read Create a Pull Request
  • Supports all screen sizes (if relevant)
  • Supports both light and dark mode (if relevant)
  • Passes npm run test

h-enk
h-enk approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@h-enk h-enk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested + verified. See also https://github.com/h-enk/doks-788

@h-enk h-enk added this to the v0.5.0 milestone Jun 21, 2022
@h-enk h-enk merged commit 0665aa1 into gethyas:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h-enk h-enk h-enk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@james-d-elliott @h-enk