Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for deferred initialization and blueprint routes in SitemapperExtend class #1

Merged
merged 1 commit into from Oct 17, 2022

Conversation

renph
Copy link
Contributor

@renph renph commented Oct 16, 2022

Thank you @h-janes for creating this amazing extension.

This PR

  • introduced a deferred initialization to the extension, check init_app
  • added support for blueprint routes
    • no need to explicitely call sitemapper.add_endpoint for large or complex project
    • endpoint name can be found by traversing app.view_functions dict

Note that blueprints must be registered before initializing sitemapper extension

All changes are made to SitemapperExtended class, we can merge these into Sitemapper class later

@h-janes
Copy link
Owner

h-janes commented Oct 17, 2022

Thank you for these important improvements! I'm glad you like the extension :)

I will work on incorporating your code into the Sitemapper class and the readme when I get a chance.

@h-janes h-janes merged commit d58cff8 into h-janes:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants