Fixes issue #2 and uses pre-defined arguments instead of **kwargs #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h-janes
deleted the
2-predefining-server_name-doesnt-allow-for-flask-serving-multiple-domains
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix predefining SERVER_NAME doesn't allow for flask serving multiple domains #2, URLs in the
Sitemapperurls list are now stored as newURLobjects rather than dicts, with methods that generate their URL loc and XML during sitemap generation. These changes are insitemapper.pyandtemplates.pyThe
Sitemappermethodsincludeandadd_endpointpreviously accepted**kwargsbut now only accept the pre-defined keyword argumentslastmodchangefreqandpriorityREADME.mdhas been improved and updated to reflect these changes.A test has been added in
test_server_name.pyto ensure that the extension respects theSERVER_NAMEif it is defined in the Flask configuration.The version number has been incremented to 1.5.0 to reflect these changes and prepare for the next release.