Fix InvalidMutabilityException in RegexToken #41
Conversation
| @@ -40,8 +37,7 @@ public actual class RegexToken : Token { | |||
| } | |||
|
|
|||
| override fun match(input: CharSequence, fromIndex: Int): Int { | |||
| relativeInput.input = input | |||
| relativeInput.fromIndex = fromIndex | |||
| val relativeInput = RelativeInput(fromIndex, input) | |||
There was a problem hiding this comment.
After this change, an instance of RelativeInput is created on each invocation of match, which, if not properly optimized, might cause a performance drop. I'd like to check how the benchmarks run on a native platform before and after the change.
There was a problem hiding this comment.
Hmm, benchmarks subproject does not seem to support native targets. Do you want me to add one?
|
Also, how does the |
|
@h0tk3y sorry, the last month was very busy for me. I have added a test showing how to reproduce the error in concurrent scenario. |
|
@h0tk3y ping |
|
It seems like the fix doesn't affect the Kotlin/Native benchmarks in any noticeable way. I'm accepting it now and will publish a new release sometime soon. Thanks a lot! |
|
@h0tk3y thanks for merging the PR. How soon can we expect the new version to be released? |
Mutating
relativeInputmakes better-parse throwInvalidMutabilityExceptionon iosX64 (probably on other Kotlin/Native platforms as well). This PR turnsrelativeInputinto a local immutable object.