Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user.rs:38-43: Apply XMLed user to the <users/> node in... #73

Open
0pdd opened this issue Jul 11, 2024 · 2 comments
Open

user.rs:38-43: Apply XMLed user to the <users/> node in... #73

0pdd opened this issue Jul 11, 2024 · 2 comments
Assignees
Labels
bug Something isn't working pdd

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jul 11, 2024

The puzzle 17-2c1e333d from #17 has to be resolved:

// @todo #17:40min Apply XMLed user to the <users/> node in storage.
// We should apply XMLed user to the <users> XML node in storage. First we
// need to check that user with provided name does not exist, and only then
// apply it to the storage. Keep in mind that application function in the
// storage should be thread-safe (as well as #xml function). Don't forget to
// create unit tests that prove that.

The puzzle was created by @h1alexbel on 11-Jul-24.

Estimate: 40 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@0pdd 0pdd added bug Something isn't working pdd labels Jul 11, 2024
0pdd referenced this issue Jul 11, 2024
feat(#17): register_user, Storage redesigned to struct
Copy link

@0pdd thanks for the report, here is a feedback:

  • The todo message is quite clear and informative, mentioning the necessary actions and context.
  • However, it would be better to remove the specific time duration (internal endpoint for user account creation #17:40min) from the todo message as it might be misleading and does not provide any value to the reader.
  • The todo message should also include the priority level, so that other developers can understand the urgency of the task.

In summary, the todo message could be improved by removing the time duration and adding a priority level. This will make the message more actionable and helpful for other developers.

Please fix the bug report in order it to get resolved faster.
Analyzed with Phind/Phind-CodeLlama-34B-v2

@0pdd
Copy link
Collaborator Author

0pdd commented Jul 11, 2024

@0pdd thanks for the report, here is a feedback: * The todo message is quite clear and informative, ...

I see you're talking to me, but I can't reply since I'm not a chat bot.

@h1alexbel h1alexbel self-assigned this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pdd
Projects
None yet
Development

No branches or pull requests

2 participants