Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aiohttp): compatible with non aiohttp projects #67

Merged
merged 2 commits into from Mar 24, 2020
Merged

fix(aiohttp): compatible with non aiohttp projects #67

merged 2 commits into from Mar 24, 2020

Conversation

LKI
Copy link
Contributor

@LKI LKI commented Mar 24, 2020

No description provided.

@h2non
Copy link
Owner

h2non commented Mar 24, 2020

This should not be necessary. What Python runtime are you using?

@LKI
Copy link
Contributor Author

LKI commented Mar 24, 2020

I use python 3.7.5 (on Windows), here are some info may helps:

$ python --version 
Python 3.7.5

$ pip list 
Package    Version
---------- -------
pip        20.0.2
setuptools 46.1.1
wheel      0.34.2

$ python 
Python 3.7.5 (tags/v3.7.5:5c02a39a0b, Oct 15 2019, 00:11:34) [MSC v.1916 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import aiohttp
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ModuleNotFoundError: No module named 'aiohttp'

@h2non
Copy link
Owner

h2non commented Mar 24, 2020

Ok, I got it. I have added a small change to make the linter pass. I will merge afterward.

@LKI
Copy link
Contributor Author

LKI commented Mar 24, 2020

Thanks~

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 68.156% when pulling e39de58 on LKI:compatible into 413cca9 on h2non:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 68.156% when pulling e39de58 on LKI:compatible into 413cca9 on h2non:master.

@h2non h2non merged commit 9daa860 into h2non:master Mar 24, 2020
@h2non
Copy link
Owner

h2non commented Mar 24, 2020

New version v1.0.1 is now available on PyPI:
pip install --upgrade pook

@LKI
Copy link
Contributor Author

LKI commented Mar 24, 2020

Cool~ Thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants