Skip to content
This repository has been archived by the owner on Mar 16, 2022. It is now read-only.

support wildcard replacement in toPath middleware #85

Merged
merged 4 commits into from Dec 18, 2015
Merged

support wildcard replacement in toPath middleware #85

merged 4 commits into from Dec 18, 2015

Conversation

zaggino
Copy link
Contributor

@zaggino zaggino commented Dec 18, 2015

I've wanted to impelement what tests say, but run into some weird issue. First request works fine, all the others don't. Seems not to be an issue of my implementation since modifying one of the original tests has the same behaviour.

@zaggino zaggino closed this Dec 18, 2015
@zaggino zaggino reopened this Dec 18, 2015
@zaggino
Copy link
Contributor Author

zaggino commented Dec 18, 2015

@h2non can you take a look what could be the problem here?

@zaggino
Copy link
Contributor Author

zaggino commented Dec 18, 2015

Ok - I've fixed it, sorry for a bit of spamming :)

@zaggino
Copy link
Contributor Author

zaggino commented Dec 18, 2015

With this I'm able to do:

proxy
  .get('/api/*')
  .forward('https://api.domain.com')
  .toPath('/*')

@h2non h2non merged commit 5b838e9 into h2non:master Dec 18, 2015
h2non added a commit that referenced this pull request Dec 18, 2015
h2non added a commit that referenced this pull request Dec 18, 2015
h2non added a commit that referenced this pull request Dec 18, 2015
@h2non
Copy link
Owner

h2non commented Dec 18, 2015

@zaggino I did some refactors. Take a look and let me know: 697887b

@h2non
Copy link
Owner

h2non commented Dec 18, 2015

This feature is now available in rocky@0.4.9. Feel free to update your dependency tree.

@zaggino
Copy link
Contributor Author

zaggino commented Dec 18, 2015

Thanks for the quick merge :)

@zaggino
Copy link
Contributor Author

zaggino commented Jan 4, 2016

I've updated to 0.4.10 and can confirm everything works fine now. Thanks

@kevingilbert100
Copy link

kevingilbert100 commented Mar 28, 2018

This does not work with .routeAll()

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants