New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API of `first` and `count` functions #1177

Closed

st-pasha opened this issue Jul 18, 2018 · 0 comments · Fixed by #1213

Assignees

Labels

improve test

Milestone

Contributor

st-pasha commented Jul 18, 2018 •

edited

Currently both functions are defined as first(iterable, start=0) and count(iterable, start=0). The following fixes are needed:

Parameter start is not used in these functions -- remove
When iterable is not a BaseExpr they do nothing. However, it makes sense to define these functions for an arbitrary python iterable too - as the name of the parameter suggests.
The iterable in count() should default to None, so that count() is valid too. This should return a special BaseExpr that computes the number of rows in each group.

In addition, we need to add tests for both of these functions.

The text was updated successfully, but these errors were encountered:

st-pasha added improve test labels

st-pasha assigned oleksiyskononenko

st-pasha mentioned this issue

Aggregator #1156

Merged

oleksiyskononenko mentioned this issue

Fixing API for first() and count() functions #1213

Merged

st-pasha closed this as completed in #1213

st-pasha added this to the Release 0.7.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment