New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for python in
operator in filtering functions
#699
Comments
in
operator in filtering functions
Update https://stackoverflow.com/questions/61494957 when this is implemented |
Any updates when this might be implemented? |
I guess the core maintainers are currently focused on building up the time series functionality in datatable; however, since it is open source, contributions are very much welcome. |
I doubt I have the skills and deep level understanding to contribute such a feature. The fact that this feature is still missing implies to me that it takes some time and sophistication to develop it, hence the maintainers weren't able to include it so far. |
@Peter-Pasta I am still finding my way around the source code. The core maintainers can explain better |
We have a tutorial on creating a new datatable function: https://datatable.readthedocs.io/en/latest/develop/create-fexpr.html Now, since As for the "core" of the function, then there are two examples that are quite similar: the Overall, on a difficulty scale from 1 (easy) to 5 (hard), I would rate this task as 2 or 3. |
I think it might be easier to write a function, instead of an operator for |
Also need guidance @st-pasha @oleksiyskononenko ; when building datatable in editable mode, I dont have an |
@oleksiyskononenko @st-pasha Any ideas on how I can fix the issue above? |
@samukweku Sorry, I was on vacation last week and didn't see your message. So the main challenge with "editable mode" installations in python is that there is no official PEP standard for this, which makes it hard to provide reliable instructions here. You can try one of the following approaches:
|
@st-pasha , still having issues with the installation. Sucessfully got it as editable. However, the datatable version is 0.11.1. I uninstalled it, (pip uninstall datatable), thinking that would take care of the problem (as suggested here); however I get the error message below, when I try to run make test (make_mistakes)
python -m pytest -ra --maxfail=10 -Werror tests
ImportError while loading conftest '/home/sam/github/datatable/tests/conftest.py'.
tests/__init__.py:14: in <module>
from datatable.lib import core
E ModuleNotFoundError: No module named 'datatable'
make: *** [Makefile:59: test] Error 4 Could you kindly suggest how I can fix this? |
On my computer I have the following configuration: the repository is checked out into $ pwd
/Users/pasha/github/datatable The content of the "easy-install.pth" is $ ls ${VIRTUAL_ENV}/lib/python*/site-packages/easy-install.pth
/Users/pasha/py36/lib/python3.6/site-packages/easy-install.pth
$ cat `ls ${VIRTUAL_ENV}/lib/python*/site-packages/easy-install.pth`
/Users/pasha/github/datatable/src And I can verify that this works by checking $ python
Python 3.6.6 (v3.6.6:4cf1f54eb7, Jun 26 2018, 19:50:54)
[GCC 4.2.1 Compatible Apple LLVM 6.0 (clang-600.0.57)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import datatable
>>> datatable.__file__
'/Users/pasha/github/datatable/src/datatable/__init__.py' The import command may fail like this if the core wasn't compiled yet with either
However, if the import says that |
@st-pasha thanks; found the error on my end and fixed; the Another question: if changes are made to the C++ code, |
If you make changes to C++, you need to run |
I'd like to filter rows according to functions like
which use pythonic syntax (syntactic sugar). Currently I need to rewrite this to primitive formula, testing all elements in the list separately.
The text was updated successfully, but these errors were encountered: