Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve default threshold API #15713

Closed
maurever opened this issue Aug 24, 2023 · 4 comments · Fixed by #15714
Closed

Improve default threshold API #15713

maurever opened this issue Aug 24, 2023 · 4 comments · Fixed by #15714
Assignees
Labels
Milestone

Comments

@maurever
Copy link
Contributor

maurever commented Aug 24, 2023

Based on this issue #15712, I suggested improving our API and also doc here: https://docs.h2o.ai/h2o/latest-stable/h2o-docs/performance-and-prediction.html#prediction-threshold

  • Improve Python and R API to get default threshold (to call model.defautl_threshold())

These part will be implemented later:

  • Explain how threshold affects prediction
  • Add an example of how to get optimal thresholds for all calculated metrics (using the thresholds_and_metric_scores table)
  • Add an example of how to change the default threshold (using the reset_model_threshold function, examples here: Python and R)
@maurever maurever added this to the 3.44.0.1 milestone Aug 24, 2023
@maurever
Copy link
Contributor Author

@hannah-tillman, can you please take a look? More info in #15712. Users often ask us this question. I found out, there is no documentation on how to change the default threshold.

@maurever maurever changed the title Add reset_threshold example to Prediction section Improve default threshold API and doc for binomial classification Aug 24, 2023
@maurever
Copy link
Contributor Author

@hannah-tillman, I implemented the code part of this issue here: #15714.

@maurever
Copy link
Contributor Author

@hannah-tillman the API change is merged.

@maurever maurever changed the title Improve default threshold API and doc for binomial classification Improve default threshold API Oct 12, 2023
@maurever
Copy link
Contributor Author

This issue solves only the implementation part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants