Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete AutoEncoder mojo #15978

Closed
wendycwong opened this issue Dec 19, 2023 · 4 comments
Closed

Complete AutoEncoder mojo #15978

wendycwong opened this issue Dec 19, 2023 · 4 comments
Assignees
Labels
Milestone

Comments

@wendycwong
Copy link
Contributor

Support ticket: https://support.h2o.ai/a/tickets/107055

We have deeplearning mojo working. However, it is not clear if AutoEncoder mojo is working properly. Hence, this assignment will be to do two things:

  1. Make sure autoencoder mojo works. If not, fix it;
  2. Work with MLOPs team to make sure it works in MLOPs. Properly needs to work with MLOPs team to complete this one.
@maurever
Copy link
Contributor

The Deeplearning MOJO has already been implemented, and the autoencoder mode is also available.

Associated PRs:
#1497
#6249

We have tests for Deeplearning Autoencoder in Java, R, and Python. Everything seems ok.

I also run this test:
https://github.com/h2oai/h2o-3/blob/master/h2o-py/tests/testdir_javapredict/pyunit_pubdev_4628_pubdev_4950_deeplearning_mojo_pojo_autoencoder_NOPASS.py

It failed for the first time because the h2o.import_file function returned one more column for deep-learning mojo output., which is strange. But other prediction results are ok. After I removed the last column from the imported file, the test passed. I am still investigating this strange behavior.

cc: @wendycwong

@wendycwong
Copy link
Contributor Author

image

@wendycwong
Copy link
Contributor Author

image

@maurever
Copy link
Contributor

@wendycwong I only found a bug when using PredictCSV with autoencoder, see this PR: #16013. Otherwise, everything works.

@maurever maurever modified the milestones: 3.44.0.4, 3.46.0.1 Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants