Resolves Issue #1689: Adding filter count to column headers #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturoci
requested changes
Dec 13, 2022
There was a problem hiding this comment.
Thanks @SiddharthParatkar! Can you also please update the PR description with the screenshots of your changes in action once you are done?
Comment on lines
+28
to
+30
| /** Create a mapping between the column names and the number of filters selected for that count. */ | ||
| const columnFilterCount: { [key: string]: number; } = {} | ||
|
|
There was a problem hiding this comment.
This will not work correctly if there are multiple tables with same filter names on a page. Let's use the existing filters if possible instead.
| ? " (9+) " | ||
| : " (" + columnFilterCount[c.key] + ") " | ||
| : "" | ||
| c.name = c.name.substring(0, c.key.length) + filterCount |
There was a problem hiding this comment.
Instead of adding the filter count to the col name, we would like to have it as a separate square in the top right corner relative to the filter chevron so that it's clear that the number belongs to the filters.
| @@ -965,7 +984,7 @@ export const | |||
| sort, | |||
| isMultiple, | |||
| setFiltersInBulk | |||
| }), [filteredItems, groups, expandedRefs, isMultiple, items, m, onFilterChange, selectedFilters, selection, sort, setFiltersInBulk]) | |||
|
@SiddharthParatkar are you going to finish this or may I close this PR? |
|
I don't think I'll be able to finish, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #1689. When a filter is selected for a column that is instantiated with
filterable=True, this feature will automatically add a number for how many filters are applied to that column. For 0 filters, no number will be shown; for more than 9 filters, '9+' will be shown.