Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for no selected tab in tabs group #1776

Closed
johannes-becker-otto opened this issue Jan 3, 2023 · 6 comments · Fixed by #2118
Closed

Allow for no selected tab in tabs group #1776

johannes-becker-otto opened this issue Jan 3, 2023 · 6 comments · Fixed by #2118
Labels
feature Feature request ui Related to UI

Comments

@johannes-becker-otto
Copy link

Is your feature request related to a problem? Please describe

My application is starting to have too many tabs. At the same time tabs are nice to switch back and forth. My first approach was to add a menu.
Thanks to v 0.24.0 adding labels to menus this even looks quite smooth.
But now, when I use a link from the menu I get the following situation where the tab marking doesn't match the rest
image

Describe the solution you'd like

I found old threads about similar discussion (two sets of tabs) and understand that there is no complete solution.
My suggestion would be that if you set for ui.tabs value=None then none of the tabs is highlighted.
This would probably be practical for a few scenarios (e.g. you have a Welcome page that is not part of your tabs).

@johannes-becker-otto johannes-becker-otto added the feature Feature request label Jan 3, 2023
@mturoci
Copy link
Collaborator

mturoci commented Jan 4, 2023

Makes sense (although not sure if for your scenario), will be done as part of #1154.

However, as for the UX standpoint, you should always let your users know where they currently are within the navigation hierarchy. This means there should be always exactly 1 active tab at all times.

@johannes-becker-otto
Copy link
Author

"This means there should be always exactly 1 active tab at all times."
I agree, the underlying problem is a mix of navigations (part tabs, part menu).
Will have to rethink that part as well...

@mturoci mturoci added the ui Related to UI label Jan 9, 2023
@mturoci
Copy link
Collaborator

mturoci commented Jan 9, 2023

If you have too many nav items, maybe it will be better to replace the header with a sidenav which can accommodate more items.

@mturoci
Copy link
Collaborator

mturoci commented Aug 17, 2023

@marek-mihok please verify if this is resolved with the recent changes for #1154. If yes, close this one.

@marek-mihok
Copy link
Contributor

@mturoci the current implementation (even after #1154) is that you must have 1 tab selected at a time. When the value is set to None, the first tab is being highlighted as a default.

@mturoci
Copy link
Collaborator

mturoci commented Aug 24, 2023

I see. That's reasonable. Let's close this and reopen in case somebody comes up with a better use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature request ui Related to UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants