Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional os and arch params to wave fetch command #1910

Closed
romarioZ1000 opened this issue Mar 29, 2023 · 3 comments
Closed

Add optional os and arch params to wave fetch command #1910

romarioZ1000 opened this issue Mar 29, 2023 · 3 comments
Labels
devx Related to developer experience feature Feature request

Comments

@romarioZ1000
Copy link

Wave SDK Version, OS

alpine 3.6

Actual behavior

1

Expected behavior

2

Steps To Reproduce

  1. Do this - wave fetch

  2. Downloading https://github.com/h2oai/wave/releases/download/v0.25.2/wave-0.25.2-any-amd64.tar.gz

  3. See error - urllib.error.HTTPError: HTTP Error 404: Not Found

  4. do this - wget https://github.com/h2oai/wave/releases/download/v0.25.2/wave-0.25.2-any-amd64.tar.gz

  5. see error - Connecting to github.com (140.82.121.3:443)
    wget: server returned error: HTTP/1.1 404 Not Found

  6. do this - wget https://github.com/h2oai/wave/releases/download/v0.25.2/wave-0.25.2-linux-amd64.tar.gz

  7. Connecting to github.com (140.82.121.4:443)
    ssl_client: write: Broken pipe
    Connecting to objects.githubusercontent.com (185.199.108.133:443)
    saving to 'wave-0.25.2-linux-amd64.tar.gz'
    wave-0.25.2-linux-am 6% |******* wave-0.25.2-linux-am 100% |*********************************************************************************************************| 22.6M 0:00:00 ETA
    'wave-0.25.2-linux-amd64.tar.gz' saved

Where need change link?
Thank you!

@romarioZ1000 romarioZ1000 added the bug Bug in code label Mar 29, 2023
@mturoci
Copy link
Collaborator

mturoci commented Mar 29, 2023

Hey @romarioZ1000, can you add more info about your OS, python and pip versions? It seems like pip couldn't determine your OS type and went with any. Since we only release OS-specific versions, the fetch call returns 404.

@romarioZ1000
Copy link
Author

NAME="Alpine Linux"
ID=alpine
VERSION_ID=3.16.4
PRETTY_NAME="Alpine Linux v3.16"
HOME_URL="https://alpinelinux.org/"
BUG_REPORT_URL="https://gitlab.alpinelinux.org/alpine/aports/-/issues"

pip:
pip 22.1.1 from /usr/lib/python3.10/site-packages/pip (python 3.10)

Python:
Python 3.10.10

can i manual install from tar.gz?

@mturoci
Copy link
Collaborator

mturoci commented Mar 29, 2023

Thanks!

Since we cannot rely on pip downloading the proper platform-specific wheel file during pip install h2o-wave, we can at least show a warning informing the user what's going on. Additionally, new optional params will be introduced to wave fetch command, called platform/os and arch to let user pick the OS and architecture for wave fetch.

can i manual install from tar.gz?

Yes, wave fetch is just a convenient way for fetching (downloading) and unzipping.

@mturoci mturoci added feature Feature request devx Related to developer experience and removed bug Bug in code labels Mar 29, 2023
@mturoci mturoci changed the title wave fetch bug Add optional os and arch params to wave fetch command Mar 29, 2023
@mturoci mturoci closed this as completed in 716777c Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devx Related to developer experience feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants